We are getting 3,713 occurrences of below message when we run below command#1321
Merged
ashishvijaywargiya merged 1 commit intoJun 2, 2026
Conversation
…ew testIntegration.
2026-06-02 23:43:46,054 |main |ServiceEcaCondition |W| doRealCompare returned null, returning false
2026-06-02 23:43:46,054 |main |ServiceEcaCondition |W| doRealCompare returned null, returning false
2026-06-02 23:43:46,054 |main |ServiceEcaCondition |W| doRealCompare returned null, returning false
Here's a quick summary of the change at ServiceEcaCondition.java:205:
Before:
if (!cond) { // fires every time comparison returns false — ~3,713 warnings
Debug.logWarning("doRealCompare returned null, returning false", MODULE);
}
return cond;
After:
if (cond == null) { // fires only if doRealCompare returns null (never, currently)
Debug.logWarning("doRealCompare returned null, returning false", MODULE);
return false;
}
return cond;
!cond (unboxed Boolean inversion) was being evaluated as "is false?", causing the warning to log on every normal false result from an ECA
condition check. The intent was cond == null — guarding against an unexpected null return. The added return false inside the guard also
prevents a future NullPointerException if doRealCompare ever returns null and the caller tries to unbox it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./gradlew testIntegration
2026-06-02 23:43:46,054 |main |ServiceEcaCondition |W| doRealCompare returned null, returning false
2026-06-02 23:43:46,054 |main |ServiceEcaCondition |W| doRealCompare returned null, returning false
2026-06-02 23:43:46,054 |main |ServiceEcaCondition |W| doRealCompare returned null, returning false
Here's a quick summary of the change at ServiceEcaCondition.java:205:
Before:
if (!cond) { // fires every time comparison returns false — ~3,713 warnings
Debug.logWarning("doRealCompare returned null, returning false", MODULE);
}
return cond;
After:
if (cond == null) { // fires only if doRealCompare returns null (never, currently)
Debug.logWarning("doRealCompare returned null, returning false", MODULE);
return false;
}
return cond;
!cond (unboxed Boolean inversion) was being evaluated as "is false?", causing the warning to log on every normal false result from an ECA
condition check. The intent was cond == null — guarding against an unexpected null return. The added return false inside the guard also
prevents a future NullPointerException if doRealCompare ever returns null and the caller tries to unbox it.